Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce StaticFileSegment::BlockMeta #13226

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: introduce StaticFileSegment::BlockMeta #13226

wants to merge 8 commits into from
+342 −106

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Dec 9, 2024 •
edited
Loading

Related to History pre-merge sync#13186 as this data would need to be provided as well.

Adds StaticFileSegment::BlockMeta which would contain:

  • BlockBodyIndices
  • BlockOmmers
  • BlockWithdrawals

wip - not rfr

@joshieDo joshieDo added C-enhancement New feature or request A-db Related to the database A-static-files Related to static files labels Dec 9, 2024
@joshieDo joshieDo mentioned this pull request Dec 10, 2024
Open
@joshieDo joshieDo force-pushed the joshie/bmeta branch 7 times, most recently from 67be940 to 342105c Compare December 16, 2024 16:33
@joshieDo joshieDo force-pushed the joshie/bmeta branch 3 times, most recently from 69a497a to 9c241b1 Compare December 20, 2024 09:46
@joshieDo joshieDo force-pushed the joshie/bmeta branch 3 times, most recently from 0aace8c to b7b5e83 Compare December 27, 2024 14:01
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 27, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #13226 will not alter performance

Comparing joshie/bmeta (0e13249) with main (b69c2eb)

Summary

✅ 77 untouched benchmarks

@joshieDo joshieDo force-pushed the joshie/bmeta branch 2 times, most recently from 13acca1 to 3ca3e86 Compare December 30, 2024 13:34
@joshieDo joshieDo force-pushed the joshie/bmeta branch 3 times, most recently from e0da5d1 to d01e649 Compare January 2, 2025 17:16
@joshieDo
order bmeta segment
0e13249 
put on bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita Awaiting requested review from rakita rakita will be requested when the pull request is marked ready for review rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin will be requested when the pull request is marked ready for review shekhirin is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk will be requested when the pull request is marked ready for review rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected will be requested when the pull request is marked ready for review Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst will be requested when the pull request is marked ready for review gakonst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-db Related to the database A-static-files Related to static files C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshieDo